Skip to content

Add TypeScript definition file #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Add TypeScript definition file #39

merged 2 commits into from
Jul 12, 2019

Conversation

jlfwong
Copy link
Contributor

@jlfwong jlfwong commented Aug 30, 2017

Fixes #37

@patrick91
Copy link

@jlfwong thanks for this, I copied it to my project and did some changes, if you need them:

declare module "browserstack-local" {
  interface Options {
    key: string;
    verbose: boolean;
    force: boolean;
    only: string;
    onlyAutomate: boolean;
    forceLocal: boolean;
    localIdentifier: string;
    folder: string;
    proxyHost: string;
    proxyPort: string;
    proxyUser: string;
    proxyPass: string;
    forceProxy: boolean;
    logFile: string;
    parallelRuns: string;
    binarypath: string;
    [key: string]: string | boolean;
  }

  class Local {
    start(options: Partial<Options>, callback: (error: Error) => void): void;
    isRunning(): boolean;
    stop(callback?: () => void): void;
  }
}

I've just made the stop callback optional and added the error param to the start callback

@Simsteve7
Copy link

Why is the TypeScript definition file still not merged in?

@thasmo
Copy link

thasmo commented Jul 12, 2019

Please!

@pulkitsharma07
Copy link
Contributor

Thanks @jlfwong

@pulkitsharma07 pulkitsharma07 merged commit 1ae773d into browserstack:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript definition file
5 participants